Wordpress Themes - WP Forum at BFA
There will be no more development for Atahualpa (or any other theme), and no support. Also no new registrations. I turned off the donation system. I may turn the forum to read only if it gets abused for spam. Unfortunately I have no time for the forum or the themes. Thanks a lot to the people who helped in all these years, especially Larry and of course: Paul. Take care and stay healthy -- Flynn, Atahualpa developer, Sep 2021

Wordpress Themes - WP Forum at BFA » WordPress Themes » Atahualpa 3 Wordpress theme » New Versions, & Updating »

Atahualpa 3.7.26 - removed (some) IE6 references - 'jQuery Migrate Helper' not needed


  #1  
Old May 21, 2021, 07:40 AM
juggledad's Avatar
juggledad
 
23,765 posts · Mar 2009
OSX 10.11.5 WP 4.x Atahualpa(all) Safari, Firefox, Chrome
The attached version of Atahualpa (v3.7.26) has some of the IE6 code removed. There is still some in there but it shouldn't effect anything. This should allow Atahualpa to run without needing the 'jQuery Migrate Helper' plugin.

A big thanks to extremecarver for figuring out some of the code that needed removing!
Attached Files
File Type: zip atahualpa.zip (1.10 MB, 200 views)
__________________
"Tell me and I forget, teach me and I may remember, involve me and I learn." - Benjamin Franklin
Juggledad | Forum Moderator/Support
  #2  
Old Jun 6, 2021, 03:47 PM
extremecarver
 
117 posts · Jul 2009
Is there a difference to what I told to delete? Actually I noticed some error messages on top of my content and solved it by putting css to external file:

add_action('admin_print_footer_scripts',function() { echo ''},99 );


is the error message on top and it is actually hard to see. I think I only started seeing that line since moving to PHP8 (which does not mean that problem has not been there on php 7.4, as php8 is much stricter on errors)

(note this bug is happening both on 3.7.26 as well as on my patched 3.7.25 version)
__________________
Don't settle for lousy expensive Maps - Get free Maps based on Openstreetmap with great autorouting for cyclists, hikers and Mountainbikers at http://openmtbmap.org

Last edited by extremecarver; Jun 6, 2021 at 04:47 PM.
  #3  
Old Yesterday, 09:45 AM
extremecarver
 
117 posts · Jul 2009
Is it possible that the js.php has a } too much at line 107?

I get a Uncaught SyntaxError: missing ) after argument list

and then the problematic lines as:

Code:
jQuery(document).ready(function(){ 
    
   
  

	 jQuery('ul#rmenu').superfish(); 
	/* jQuery('ul#rmenu').superfish().find('ul').bgIframe({opacity:false}); */
 
	}
If I remove line 107 I have one error less in console - I think the closing is not correct.
The overall count of opening ampersand "{" is 62 while there are 63 "}" closing ampersands. This should not be right - or why should one ampersand be opened from another file?
__________________
Don't settle for lousy expensive Maps - Get free Maps based on Openstreetmap with great autorouting for cyclists, hikers and Mountainbikers at http://openmtbmap.org
  #4  
Old Yesterday, 09:56 AM
extremecarver
 
117 posts · Jul 2009
Actually also the inline/external errors are gone then. This line 107 in js.php is surely not supposed to be there and happened due to a wrong removal of lines on this version!

And after comparing with 3.7.25 it's very easy to see how ˛juggledad made this error - The closing bracket (which I correctly mentioned in my 3.7.25 bugreport) was incorrectly behind the remark line /* End IE6 */ but is opened from within. So it really has to be removed.
Well I do not think it causes great harm because the other () normal brackets luckily catch if from doing so - but it really should be removed.
__________________
Don't settle for lousy expensive Maps - Get free Maps based on Openstreetmap with great autorouting for cyclists, hikers and Mountainbikers at http://openmtbmap.org

Last edited by extremecarver; Yesterday at 10:04 AM.

Bookmarks

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes


Similar Threads
Thread Thread Starter Forum Replies Last Post
Libraries : jquery-1.2.6 is needed ? nello Atahualpa 3 Wordpress theme 1 Jun 18, 2009 04:11 PM


All times are GMT -6. The time now is 08:42 PM.


Powered by vBulletin® Copyright ©2000 - 2021, Jelsoft Enterprises Ltd.