Wordpress Themes - WP Forum at BFA
Click here to register or to donate.
Auto self-registration is not available here - far too many spammers. This forum has many, many backlinks and because of that there is an intense desire among spammers to drop their links here.

Wordpress Themes - WP Forum at BFA » WordPress Themes » Montezuma Theme »

[SOLVED] Thumb Shadow and Post Thumb BUG ?


  #1  
Old Mar 22, 2014, 10:49 AM
KatyDigg's Avatar
KatyDigg
 
319 posts · Jul 2009
Hello,

Just started work on my new site employing Montezuma 1.1.9.

WP 3.8.1

No Plugins.

Ran W3C Validation result: passed.

Created 2 posts, one with no image in post & one with an image in post.

Re-run W3C validation result: failed

2 Errors with reason being "Bad Value" as follows:

Error
Code:
<div class="thumb-shadow"><div class="post-thumb"><a href="http://www.katydiggtest.com/wordpress/testimage/"><img src="http://www.katydiggtest.com/wp-content/uploads/testimage-620x 180-1.jpg" width="620" height=" 180" alt="My Test Image for Montezuma 1.1.9"/></a></div></div>
Whereas to pass, the indicated correct code should be as follows:

Correct
Code:
<div class="thumb-shadow post-thumb"><a href="http://www.katydiggtest.com/wordpress/testimage/"><img src="http://www.katydiggtest.com/wp-content/uploads/testimage-620x%20180-1.jpg" width="620" height=" 180" alt="My Test Image for Montezuma 1.1.9"></a></div>

Kind regards,

Katy

Last edited by KatyDigg; Mar 22, 2014 at 03:38 PM. Reason: typo
  #2  
Old Mar 22, 2014, 11:29 AM
juggledad's Avatar
juggledad
 
23,687 posts · Mar 2009
OSX 10.11.5 WP 4.x Atahualpa(all) Safari, Firefox, Chrome
If you run the code thru 4 different validators, you will most likely get 4 different results. I personally don't pay attention to validators. Run some big name sites thru the validator and see what happened.

The code is valid HTML, a div with in a div, the validator just doesn't know how to handle it, but all the browsers do….

if you want to fix it, go into the virtual subtemplate postformat and change it.
__________________
"Tell me and I forget, teach me and I may remember, involve me and I learn." - Benjamin Franklin
Juggledad | Forum Moderator/Support

Last edited by juggledad; Mar 22, 2014 at 11:32 AM.
  #3  
Old Mar 22, 2014, 03:30 PM
KatyDigg's Avatar
KatyDigg
 
319 posts · Jul 2009
Hi Juggledad,

With all due respect, we've discussed W3C validation previously, and it is important (as per web design and development training and associated web standards).

Flynn makes mention of W3C validation in the formal introduction to Montezuma Theme.

With regard to the "Bug" error problem - occurs upon uploading image to post and only occurs with Montezuma.

i.e I switched theme to WP Default Twenty Fourteen and ran W3C validation and it did not occur (passed).

I am referring to the exact same problem as this 2013 thread http://forum.bytesforall.com/showthread.php?t=20248.

Montezuma adds -620x 180-1 (note the WHITE SPACE) to the end of img src url string.

Code:
<img src="http://www.katydiggtest.com/wp-content/uploads/testimage-620x 180-1.jpg" width="620"
Many thanks,

Katy

Last edited by KatyDigg; Mar 22, 2014 at 03:36 PM.
  #4  
Old Mar 22, 2014, 04:31 PM
KatyDigg's Avatar
KatyDigg
 
319 posts · Jul 2009
Hi again,

Just created this test site, and uploaded a small image to a test post.

Run W3C Validator and the result is as follows:

Code:
Error Line 78, Column 206: Bad value http://www.testsite.org/wp-content/uploads/Owl-620x 180-1.png for attribute src on element img: Illegal character in path segment: not a URL code point.

    …ent/uploads/Owl-620x 180-1.png" width="337" height="180" alt="Test"/></a></div>

    Syntax of IRI reference:

        Any URL. For example: /hello, #canvas, or http://example.org/. Characters should be represented in NFC and spaces should be escaped as %20.

Once again -620x 180-1.png (note WHITE SPACE which could create a 404 error) is added to img src url string.


As mentioned in previous posting, this has been questioned previously here http://forum.bytesforall.com/showthread.php?t=20248.

Many thanks,

Katy

Last edited by KatyDigg; Mar 22, 2014 at 04:35 PM. Reason: http://forum.bytesforall.com/showthread.php?t=20248
  #5  
Old Mar 22, 2014, 04:52 PM
juggledad's Avatar
juggledad
 
23,687 posts · Mar 2009
OSX 10.11.5 WP 4.x Atahualpa(all) Safari, Firefox, Chrome
Quote:
As mentioned in previous posting, this has been questioned previously here http://forum.bytesforall.com/showthread.php?t=20248.
and you will notice thatt the poster of that thead never replied to the question that was asked

You can get rid of the space by changing the bra_thumb in the virtual sub template 'postformat from
HTML Code:
<?php bfa_thumb( 620, 180, true, '<div class="thumb-shadow"><div class="post-thumb">', '</div></div>' ); ?>
to
HTML Code:
<?php bfa_thumb( 620,180, true, '<div class="thumb-shadow"><div class="post-thumb">', '</div></div>' ); ?>
i.e. remove the space after the comma and before the value for the height

btw, go validate 'wordpress.org' and see what results
__________________
"Tell me and I forget, teach me and I may remember, involve me and I learn." - Benjamin Franklin
Juggledad | Forum Moderator/Support

Last edited by juggledad; Mar 22, 2014 at 04:56 PM.
  #6  
Old Mar 22, 2014, 05:13 PM
KatyDigg's Avatar
KatyDigg
 
319 posts · Jul 2009
Hi Juggledad,

Quote:
Originally Posted by juggledad

btw, go validate 'wordpress.org' and see what results
I don't tend to validate other sites, instead, I focus on the resources I'm working with.

Quote:

i.e. remove the space after the comma and before the value for the height
I've removed the space and PASSED W3C validation.

Thank you for you help, Juggledad, I shall send a donation to you, and also to Flynn, by way of "Thank You" for Montezuma Theme ... superb to work with.

Hope you have a lovely weekend.

Many thanks,

Katy

Last edited by KatyDigg; Mar 22, 2014 at 05:13 PM. Reason: typo
  #7  
Old Mar 22, 2014, 05:22 PM
juggledad's Avatar
juggledad
 
23,687 posts · Mar 2009
OSX 10.11.5 WP 4.x Atahualpa(all) Safari, Firefox, Chrome
just to let you know, I have found where the issue comes from. If you want to change the code: edit parse_php.php and after line 165, which should be
HTML Code:
	$php_string = str_replace( array( "\r", "\n", "\t" ), "", $php_string );
add the following line
HTML Code:
	$php_string = str_replace( ", ", ",", $php_string );
this 'may' make it into version 1.2.0 which should be being submitted to Wordpress for review this weekend. Hopefully Flynn will get it in before he submits it.
__________________
"Tell me and I forget, teach me and I may remember, involve me and I learn." - Benjamin Franklin
Juggledad | Forum Moderator/Support

Bookmarks

Tags
1.1.9, montezuma theme, post thumb, thumb shadow, w3c validation

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes


Similar Threads
Thread Thread Starter Forum Replies Last Post
[SOLVED] Image wrapper <div class="thumb-shadow"> skyfire Montezuma Theme 23 Apr 28, 2013 05:44 PM
thumb image blogmaster2003 Montezuma Theme 2 Oct 18, 2012 08:12 AM
Thumb support in Atahualpa? kjetil Atahualpa 3 Wordpress theme 9 Feb 10, 2011 08:05 AM
Show thumb left of entire post, not just content ScottAllen Excerpts, Read more, Pagination 1 Jan 27, 2010 07:12 AM


All times are GMT -6. The time now is 01:52 AM.


Powered by vBulletin® Copyright ©2000 - 2018, Jelsoft Enterprises Ltd.