Wordpress Themes - WP Forum at BFA
Click here to register or to donate.
Auto self-registration is not available here - far too many spammers. This forum has many, many backlinks and because of that there is an intense desire among spammers to drop their links here.

Wordpress Themes - WP Forum at BFA » WordPress Themes » Atahualpa 3 Wordpress theme » New Versions, & Updating »

Atahualpa 3.7.12 site logo missing on clean install


  #1  
Old May 10, 2013, 03:18 AM
mdmower's Avatar
mdmower
 
76 posts · Jul 2010
Missouri, USA
There's are a couple little bugs related to the new image directory options in 3.7.12 for users who freshly install atahualpa, or reset all settings to defaults. The site logo and fav-icon get incorrect paths if 'ata_images_dir' hasn't been written to the database yet. Easy fixes:

bfa_header_config.php

Change lines 154-155 from this:
Code:
$img_folder = 'ata-images';  
$imgdir  = content_url() . '/ata-images/';
to this:
Code:
$imgdir  = get_template_directory_uri() . '/images/';
header.php

Change lines 48 from this:
Code:
$imgdir  = content_url() . '/ata-images/';
to this:
Code:
$imgdir  = get_template_directory_uri() . '/images/favicon/';

Last edited by mdmower; May 16, 2013 at 07:28 PM.
  #2  
Old May 10, 2013, 05:04 AM
juggledad's Avatar
juggledad
 
23,576 posts · Mar 2009
OSX 10.11.5 WP 4.x Atahualpa(all) Safari, Firefox, Chrome
That will break the new functionality. All you need do is go to ato->New Image Locations and press the 'Save Changes' button.
  #3  
Old May 10, 2013, 11:40 AM
mdmower's Avatar
mdmower
 
76 posts · Jul 2010
Missouri, USA
Quote:
Originally Posted by juggledad
That will break the new functionality. All you need do is go to ato->New Image Locations and press the 'Save Changes' button.
I think you're speaking before testing. I see no breaking of functionality.
  #4  
Old May 10, 2013, 12:13 PM
lmilesw's Avatar
lmilesw
 
10,174 posts · Jul 2009
Central New York State USA
The idea of the new functionality is to allow you to have the images outside of the template directory.
__________________
~Larry (CNY Web Designs)
This site should be a membership site since it so full of good stuff.
Please consider donating which gives you access to even more good stuff.
  #5  
Old May 10, 2013, 12:39 PM
mdmower's Avatar
mdmower
 
76 posts · Jul 2010
Missouri, USA
Quote:
Originally Posted by lmilesw
The idea of the new functionality is to allow you to have the images outside of the template directory.
Yep... and I'm not breaking this ability.
  #6  
Old May 16, 2013, 07:43 PM
mdmower's Avatar
mdmower
 
76 posts · Jul 2010
Missouri, USA
I updated the first post to reflect that the same problem affects favicons. Before you guys dismiss this suggestion -- as seems to be the case considering earlier responses -- can you actually pull up the code and take a look? Consider the if statements around the code I'm suggesting should be changed:
Code:
if( !isset($bfa_ata['ata_images_dir']) OR ($bfa_ata['ata_images_dir'] == '') )
In 3.7.12, the code that runs if the above is satisfied is $imgdir = content_url() . '/ata-images/';. There are two problems here:
  1. /ata-images/ is hard-coded (must be left-over from an earlier version of this functionality)
  2. content_url() should NOT be the path called when $bfa_ata['ata_images_dir'] is unset/empty
The else statement below this correctly captures user-specified directories.

Last edited by lmilesw; May 16, 2013 at 08:07 PM.
  #7  
Old May 16, 2013, 09:00 PM
juggledad's Avatar
juggledad
 
23,576 posts · Mar 2009
OSX 10.11.5 WP 4.x Atahualpa(all) Safari, Firefox, Chrome
The problem is that the new option adds an entry into an array but does not initialize it. With your changes if someone selects wp-content as the root and the folder they name does NOT exist (say they misspell it), it will default to the Atahualpa images folder and they won't see their images.

I'll be looking into a fix for the array when I get a chance.

Last edited by lmilesw; May 16, 2013 at 11:35 PM.
  #8  
Old May 17, 2013, 11:36 AM
mdmower's Avatar
mdmower
 
76 posts · Jul 2010
Missouri, USA
Quote:
Originally Posted by juggledad
With your changes if someone selects wp-content as the root and the folder they name does NOT exist (say they misspell it), it will default to the Atahualpa images folder and they won't see their images.
In the example you mention, the image paths will not revert to the default atahualpa images folder. This only occurs if ata_images_dir is undefined or empty. Their incorrect folder name will result (as it should) in broken links to images.

Perhaps there is one misconception I have though: I assumed defining your own image folder required it be located under wp-content/. Is it actually the case that users can specify an alternate images folder under atahualpa (not a good idea)?

Last edited by mdmower; May 17, 2013 at 11:38 AM.
  #9  
Old May 17, 2013, 12:54 PM
juggledad's Avatar
juggledad
 
23,576 posts · Mar 2009
OSX 10.11.5 WP 4.x Atahualpa(all) Safari, Firefox, Chrome
Your assumption is correct, the alternative location is within wp-content. The idea is that when you do an automatic upgrade, WordPress wipes out the contents of the theme folder and puts the new version in. By moving the images out of the theme folder, they will remain over upgrades.

Bookmarks

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes


Similar Threads
Thread Thread Starter Forum Replies Last Post
Completely clean install of WP3.1 and Atahualpa 3.6.4 nothing displays. Miach Atahualpa 3 Wordpress theme 4 Mar 8, 2011 03:17 PM
"Atahualpa theme options" link missing from Site admin page mogf01 Multisite 6 Sep 2, 2010 07:05 PM
Clean Options with Atahualpa adum Plugins & Atahualpa 1 Jul 13, 2010 07:42 PM
"Not Found" error in latest version on clean install lintunen New Versions, & Updating 18 Feb 23, 2010 01:05 AM
Clean install went south lmilesw New Versions, & Updating 4 Feb 21, 2010 11:58 AM


All times are GMT -6. The time now is 12:43 PM.


Powered by vBulletin® Copyright ©2000 - 2018, Jelsoft Enterprises Ltd.