Wordpress Themes - WP Forum at BFA
Click here to register or to donate.
Auto self-registration is not available here - far too many spammers. This forum has many, many backlinks and because of that there is an intense desire among spammers to drop their links here.

Wordpress Themes - WP Forum at BFA » WordPress Themes » Atahualpa 3 Wordpress theme » New Versions, & Updating »

Bug on translation


  #1  
Old Mar 10, 2011, 08:27 AM
mkbiss
 
1 posts · Mar 2011
Hi,

on file atahualpa/comments.php (version 3.6.4) at row 115 I have this istruction:

PHP Code:
$comment_form_settings = array(
    
'fields'               => apply_filters'comment_form_default_fields'$fields ),
    
'comment_field'        => '<p><textarea name="comment" id="comment" rows="10" cols="10" tabindex="4"></textarea></p>',
    
'must_log_in'          => '<p class="must-log-in">' .  sprintf__'You must be <a href="%s">logged in</a> to post a comment.' ), wp_login_urlapply_filters'the_permalink'get_permalink$post_id ) ) ) ) . '</p>',
    
'logged_in_as'         => '<p class="logged-in-as">' sprintf__'Logged in as <a href="%1$s">%2$s</a>. <a href="%3$s" title="Log out of this account">Log out?</a>' ), admin_url'profile.php' ), $user_identitywp_logout_urlapply_filters'the_permalink'get_permalink$post_id ) ) ) ) . '</p>',
    
'comment_notes_before' => '',
    
'comment_notes_after'  => $comment_notes_after,
    
'id_form'              => 'commentform',
    
'id_submit'            => 'submit',
    
'title_reply'          => __'Leave a Reply' ),
    
'title_reply_to'       => __'Leave a Reply to %s' ),
    
'cancel_reply_link'    => __'Cancel reply' ),
    
'label_submit'         => __'Post Comment' )
); 
The "__" function don't set the second parameter to 'atahualpa'. Example:
PHP Code:
'title_reply'          => __'Leave a Reply' ), 
becomes
PHP Code:
'title_reply'          => __'Leave a Reply''atahualpa' ), 
I don't search on all files to test if this problem is present into others file.
By,
Michele
sorry for my english
  #2  
Old Mar 10, 2011, 09:21 PM
Knut Sparhell
 
34 posts · Jun 2010
Fredrikstad, Norway
The second parameter to the __() function, the textdomain, is optional and defaults to 'default'. This means that the string will be translated if, and only if, it's found in the default textdomain. The default domain is the one of WordPress itself.

So this may work if the string, here "Leave a Reply", is found in WordPress and translated to your language. The problem is that such strings may change from one WordPress release to another.

So I support that this should be fixed.
  #3  
Old Mar 11, 2011, 09:46 AM
juggledad's Avatar
juggledad
 
23,576 posts · Mar 2009
OSX 10.11.5 WP 4.x Atahualpa(all) Safari, Firefox, Chrome
Added to 3.6.5 TODO
__________________
"Tell me and I forget, teach me and I may remember, involve me and I learn." - Benjamin Franklin
Juggledad | Forum Moderator/Support

Bookmarks

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes


Similar Threads
Thread Thread Starter Forum Replies Last Post
Translation to it_IT ragdoll Languages & Translations 1 Apr 8, 2011 05:49 AM
BUG - menu bar bug - Atahualpa 3.5.1 - WP 3.0 David Campbell New Versions, & Updating 0 Jun 26, 2010 04:14 PM
Hungarian translation Ufovadasz Languages & Translations 0 Mar 14, 2010 08:53 AM
French translation cactus02 Languages & Translations 1 Sep 18, 2009 03:45 PM
Russian translation leah74 Languages & Translations 1 Mar 26, 2009 04:55 PM


All times are GMT -6. The time now is 08:59 AM.


Powered by vBulletin® Copyright ©2000 - 2018, Jelsoft Enterprises Ltd.