Wordpress Themes - WP Forum at BFA
Click here to register or to donate.
Auto self-registration is not available here - far too many spammers. This forum has many, many backlinks and because of that there is an intense desire among spammers to drop their links here.

Wordpress Themes - WP Forum at BFA » WordPress Themes » Atahualpa 3 Wordpress theme » New Versions, & Updating » Old Version fixes and change logs »

BUGFIX 361-02: Tab order on comment form incorrect when user is not logged in


  #1  
Old Jan 13, 2011, 04:37 AM
juggledad's Avatar
juggledad
 
23,682 posts · Mar 2009
OSX 10.11.5 WP 4.x Atahualpa(all) Safari, Firefox, Chrome
If a user is not logged in, then the tab order of the comment form fields is incorrect. To fix this issue, edit comments.php and change lines 93-101 from

HTML Code:
// author, email and url fields are set in a separate variable first:
$fields =  array(
	'author' => '<p><input class="text author" id="author" name="author" type="text" value="' . esc_attr( $commenter['comment_author'] ) . '" size="30"' . $aria_req . ' tabindex="1" />' . 
				'&nbsp;&nbsp;<label for="author"><strong>' . __( 'Name' ) . '</strong> ' . ( $req ? __('(required)','atahualpa') : '' ) . '</label></p>',
	'email'  => '<p><input class="text email" id="email" name="email" type="text" value="' . esc_attr(  $commenter['comment_author_email'] ) . '" size="30"' . $aria_req . ' />' . 
				'&nbsp;&nbsp;<label for="email"><strong>' . __( 'Email' ) . '</strong> ' . ( $req ? __('(will not be published) (required)','atahualpa') : '' ) . '</label></p>',
	'url'    => '<p><input class="text url" id="url" name="url" type="text" value="' . esc_attr( $commenter['comment_author_url'] ) . '" size="30" />' . 
				'&nbsp;&nbsp;<label for="url">' . __( 'Website' ) . '</label></p>'
); 
to
HTML Code:
// author, email and url fields are set in a separate variable first:
$fields =  array(
	'author' => '<p><input class="text author" id="author" name="author" type="text" value="' . esc_attr( $commenter['comment_author'] ) . '" size="30"' . $aria_req . ' tabindex="1" />' . 
				'&nbsp;&nbsp;<label for="author"><strong>' . __( 'Name' ) . '</strong> ' . ( $req ? __('(required)','atahualpa') : '' ) . '</label></p>',
	'email'  => '<p><input class="text email" id="email" name="email" type="text" value="' . esc_attr(  $commenter['comment_author_email'] ) . '" size="30"' . $aria_req . '  tabindex="2" />' . 
				'&nbsp;&nbsp;<label for="email"><strong>' . __( 'Email' ) . '</strong> ' . ( $req ? __('(will not be published) (required)','atahualpa') : '' ) . '</label></p>',
	'url'    => '<p><input class="text url" id="url" name="url" type="text" value="' . esc_attr( $commenter['comment_author_url'] ) . '" size="30"  tabindex="3" />' . 
				'&nbsp;&nbsp;<label for="url">' . __( 'Website' ) . '</label></p>'
); 
or you can use the attached file which has the changes already applied. Download the file, unzip it and upload it to your Atahualpa 3.6.1 theme folder.
comments.php.zip
__________________
"Tell me and I forget, teach me and I may remember, involve me and I learn." - Benjamin Franklin
Juggledad | Forum Moderator/Support
  #2  
Old Feb 25, 2011, 03:38 PM
Linoge
 
2 posts · Mar 2010
I hate to be the bearer of bad news, but this fix does not appear to be working, even when I am logged in. Pressing "Tab" from the comment form takes the highlight up to the first link on the page, and never seems to get back around to the "Submit" button.
  #3  
Old Feb 25, 2011, 04:27 PM
juggledad's Avatar
juggledad
 
23,682 posts · Mar 2009
OSX 10.11.5 WP 4.x Atahualpa(all) Safari, Firefox, Chrome
Without this fix you would jump from the 'Name' to the 'Message Text' to the top of the document to possibly other places then finally to the 'Email' then Website.

the actual Comment form is built with a WordPress function and that code puts no tabindex on the submit button.

If you want, you can edit 'comment-template.php' which is in the 'wordpress/includes' folder and find line 1577 (in WP 3.0.5) which should be
HTML Code:
							<input name="submit" type="submit" id="<?php echo esc_attr( $args['id_submit'] ); ?>" value="<?php echo esc_attr( $args['label_submit'] ); ?>" />
and change it to
HTML Code:
							<input name="submit" type="submit" id="<?php echo esc_attr( $args['id_submit'] ); ?>" tabindex="5"  value="<?php echo esc_attr( $args['label_submit'] ); ?>" />
and that will add a tab to the Submit button.
__________________
"Tell me and I forget, teach me and I may remember, involve me and I learn." - Benjamin Franklin
Juggledad | Forum Moderator/Support
  #4  
Old Feb 26, 2011, 07:26 AM
Linoge
 
2 posts · Mar 2010
Well, in that case, cancel my complaints and thanks for the pointer!

Bookmarks

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes


Similar Threads
Thread Thread Starter Forum Replies Last Post
BUGFIX 361-01: meta tags not appearing in generated source juggledad Old Version fixes and change logs 5 Jan 13, 2011 03:57 AM
[SOLVED] Exclude sidebar for logged-in user everyman Sidebars & Widgets 4 Oct 24, 2010 06:13 PM
New Widget Area named after logged user ID thanos Sidebars & Widgets 9 Sep 13, 2010 07:15 PM
[SOLVED] BUGFIX - 3.4.1-&gt;3.4.6 - Comment form will not show up after first comment on juggledad Comments, trackbacks & pings 49 Jul 29, 2010 06:01 PM
BUGFIX 351/352-03: Comment Form Anchor Link gets a 404 (Not found) juggledad Old Version fixes and change logs 3 Jun 16, 2010 05:45 PM


All times are GMT -6. The time now is 03:15 AM.


Powered by vBulletin® Copyright ©2000 - 2018, Jelsoft Enterprises Ltd.