BUGFIX 364-02: CSS Compression does not happen if 'Allow debugging?' is 'Yes'

juggledad · #1 Feb 8, 2011, 06:51 AM

NOTE: This fix is not needed if you apply BUGFIX 364-03 since it is included in that fix.
UPDATED 2/27/11 - was missing some code change at the end - the ZIP file reflects the additional changes

Thanks to mdmower for noticing this

(note: this is NOT a critical fix it is cosmetic)

Due to changes in the code in 3.6.x, if you set the 'ATO->Configure CSS & JS->Configure CSS & JS' option to 'Yes', the 'CSS: Compress' option will be ignored.

To fix this, edit CSS.php and find line 11 which should be

HTML Code:

!( isset($bfa_ata_debug) AND $bfa_ata['allow_debug'] == "Yes" ) ) {

and change it to

HTML Code:

!( $bfa_ata_debug == 1 AND $bfa_ata['allow_debug'] == "Yes" ) ) {

change lines 944-951 from

HTML Code:

if ( $bfa_ata['css_compress'] == "Yes" AND 
!( isset($bfa_ata_debug) AND $bfa_ata['allow_debug'] == "Yes" ) ) {
	ob_end_flush();
}	
if ( isset($bfa_ata_preview) OR $bfa_ata['css_external'] == "Inline" OR 
( isset($bfa_ata_debug) AND $bfa_ata['allow_debug'] == "Yes" ) ) {
	echo "</style>\n"; 
}

to

HTML Code:

if ( $bfa_ata['css_compress'] == "Yes" AND 
!( $bfa_ata_debug == 1 AND $bfa_ata['allow_debug'] == "Yes" ) ) {
	ob_end_flush();
}	
if ( isset($bfa_ata_preview) OR $bfa_ata['css_external'] == "Inline" OR 
( $bfa_ata_debug == 1 AND $bfa_ata['allow_debug'] == "Yes" ) ) {
	echo "\n</style>\n"; 
}

or you can replace CSS.PHP with the attached version which has the change applied.