Wordpress Themes - WP Forum at BFA

Wordpress Themes - WP Forum at BFA (http://forum.bytesforall.com/index.php)
-   Old Version fixes and change logs (http://forum.bytesforall.com/forumdisplay.php?f=37)
-   -   BUGFIX 364-02: CSS Compression does not happen if 'Allow debugging?' is 'Yes' (http://forum.bytesforall.com/showthread.php?t=12685)

juggledad Feb 8, 2011 06:51 AM

BUGFIX 364-02: CSS Compression does not happen if 'Allow debugging?' is 'Yes'
 
1 Attachment(s)
NOTE: This fix is not needed if you apply BUGFIX 364-03 since it is included in that fix.
UPDATED 2/27/11 - was missing some code change at the end - the ZIP file reflects the additional changes

Thanks to mdmower for noticing this

(note: this is NOT a critical fix it is cosmetic)

Due to changes in the code in 3.6.x, if you set the 'ATO->Configure CSS & JS->Configure CSS & JS' option to 'Yes', the 'CSS: Compress' option will be ignored.

To fix this, edit CSS.php and find line 11 which should be
HTML Code:

!( isset($bfa_ata_debug) AND $bfa_ata['allow_debug'] == "Yes" ) ) {
and change it to
HTML Code:

!( $bfa_ata_debug == 1 AND $bfa_ata['allow_debug'] == "Yes" ) ) {
change lines 944-951 from
HTML Code:

if ( $bfa_ata['css_compress'] == "Yes" AND
!( isset($bfa_ata_debug) AND $bfa_ata['allow_debug'] == "Yes" ) ) {
        ob_end_flush();
}       
if ( isset($bfa_ata_preview) OR $bfa_ata['css_external'] == "Inline" OR
( isset($bfa_ata_debug) AND $bfa_ata['allow_debug'] == "Yes" ) ) {
        echo "</style>\n";
}

to
HTML Code:

if ( $bfa_ata['css_compress'] == "Yes" AND
!( $bfa_ata_debug == 1 AND $bfa_ata['allow_debug'] == "Yes" ) ) {
        ob_end_flush();
}       
if ( isset($bfa_ata_preview) OR $bfa_ata['css_external'] == "Inline" OR
( $bfa_ata_debug == 1 AND $bfa_ata['allow_debug'] == "Yes" ) ) {
        echo "\n</style>\n";
}

or you can replace CSS.PHP with the attached version which has the change applied.

lbleier Feb 9, 2011 09:21 AM

I had high hopes for this but it didnt work. Im still getting this errror:

http://www.shelememorial.com/bug.png

runnerb0y Feb 9, 2011 09:39 AM

Your site is displaying perfectly for me. I'm using IE and FireFox.

juggledad Feb 9, 2011 11:47 AM

lbleier - you have a different issue, do a forum search on 'suhosin'

KatyDigg Feb 13, 2011 04:25 PM

Thank you, Juggledad

Much appreciated.

LANtait Feb 26, 2011 11:42 PM

BUGFIX 364-02 in css.php line 11 breaks the zebra striping in tables. (No alternate stripes)

Zebra striping works fine with the former code.

juggledad Feb 27, 2011 03:39 AM

The Zebra striping works fine with the new version.

LANtait Feb 27, 2011 10:38 PM

Quote:

Originally Posted by juggledad (Post 59138)
The Zebra striping works fine with the new version.

Thanks juggledad, my zebras are back with the new code!

LAN

KatyDigg Mar 4, 2011 03:11 PM

Implemented

Quote:

Originally Posted by juggledad (Post 57306)
UPDATED 2/27/11 - was missing some code change at the end - the ZIP file reflects the additional changes

or you can replace CSS.PHP with the attached version which has the change applied.
Attachment 1191


and I now have the following.....



<style type="text/css"><br>/*=========================================<br>isse t($bfa_ata_debug)=1<br>$bfa_ata_debug=<br>======== =================================<br>*/body{text-align:center;margin:0;padding:0;font-family:verdana,arial,sans-serif;font-size:13px;line-height:1.4;color:#333333;background:#0B3861;paddin g-top:20px;padding-bottom:20px}a:link,a:visited,a:active{color:#24006 B;font-weight:bold;text-decoration:none;}a:hover{color:#468F30;font-weight:bold;text-decoration:underline}ul,ol,dl,p,h1,h2,h3,h4,h5,h6{ margin-top:10px;margin-bottom:10px;padding-top:0;padding-bottom:0;}ul ul,ul ol,ol ul,ol ol{margin-top:0;margin-bottom:0}code,pre{font-family:"Courier New",Courier,monospace;font-size:1em}pre{overflow:auto;word-wrap:normal;padding-bottom:1.5em;overflow-y:hidden;width:99%}abbr[title],acronym[title]{border-bottom:1px dotted}hr{display:block;height:2px;border:none;mar gin:0.5em auto;color:#cccccc;background-color:#cccccc}table{font-size:1em;}div.post,ul.commentlist li,ol.commentlist li{w


In Page Source View.......

and Now W3C Validation shows 13 <br>isset($bfa_ata_debug)=1<br>$bfa_ata_… Errors

What's happening :confused:

KatyDigg Mar 4, 2011 03:26 PM

BODY STYLE background colors are now (having only recently, today, created new STYLE site!) disabled and the font sizes have changed - reduced!!!!

All was fantastic - until uploaded and installed the above css.php.zip


The BODY STYLE background colors now remain void.

KatyDigg Mar 4, 2011 04:32 PM

In the meantime, I have restored back to previous ATA 3.5.3. version and then deleted 3.6.4.

Re-installed 3.6.4.

Voila!!

Back to "normal"

All in a jiffy :)

I won't be re-installing this css.php fix

juggledad Mar 5, 2011 03:21 AM

I bad :(, that was caused by some debugging code I forgot to take out (sigh). I've removed it and this fix should be good. Not if you apply BUGFIX: 365-03 you don't need to apply this one since 365-03 includes this fix (and there is no debugging code in it :o)
Thanks Berean for picking up on that.

KatyDigg Mar 5, 2011 04:00 PM

Quote:

Originally Posted by juggledad (Post 59808)
I bad :(, that was caused by some debugging code I forgot to take out (sigh). I've removed it and this fix should be good. Not if you apply BUGFIX: 365-03 you don't need to apply this one since 365-03 includes this fix (and there is no debugging code in it :o)
Thanks Berean for picking up on that.


Thanks, Juggledad, :) I will take a look at 364-03


All times are GMT -6. The time now is 03:10 AM.

Powered by vBulletin® Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.