Wordpress Themes - WP Forum at BFA

Wordpress Themes - WP Forum at BFA (http://forum.bytesforall.com/index.php)
-   Old Version fixes and change logs (http://forum.bytesforall.com/forumdisplay.php?f=37)
-   -   Atahualpa 3.6.7 released (was 3.6.6) (http://forum.bytesforall.com/showthread.php?t=14117)

Flynn May 11, 2011 09:54 AM

Atahualpa 3.6.7 released (was 3.6.6)
 
UPDATE: Atahualpa 3.6.7 with working custom widget areas, everything up to post #7 taken care of

Download Atahualpa 3.6.7 here


Because the requirements for themes listed at wordpress.org have been restricted, the ability to add custom PHP code through the Atahualpa Theme Options had to be removed.

If you have custom PHP code somewhere in the theme options the code will be printed now instead of being executed (Edit: Except for <?php bfa_widget_area('....'); ?> which will be executed. ).
The theme options "Content above LOOP", "Loop", "Content below LOOP", "Content if NOT FOUND" are gone now, to edit the Loop or to add code before/after the loop, you'd have to manually edit Atahualpa's index.php now.

3.6.6 also contains all of Juggledad's 364-XX bugfixes

3.6.6 has been successfully checked with WP_DEBUG TRUE, and with the Theme Check plugin.

EDIT: As pointed out by Juggledad, existing custom widget areas will not work in 3.6.6 because they ARE dynamic PHP, at least if you add their code (<?php bfa_widget_area(...); ?>) through one of the Atahualpa Theme Option text areas.

3.6.7 with a fix for custom widget areas is coming later today. If you don't have any custom widget areas, 3.6.6 should work for you.

juggledad May 11, 2011 12:37 PM

Quote:

If you have custom PHP code somewhere in the theme options the code will be printed now instead of being executed.
Note, this means if you look at the source of the page you will see the code. It will probably not show when viewing the page since it is not valid HTML

Also, If you had a new widget area, these will no longer work.

Flynn May 11, 2011 12:59 PM

I'll release a new version later today with a fix for the widget areas

Custom widget areas can work again although it is dynamic PHP, because it is only 1 predictable piece of PHP, which can be replaced with the actual output of bfa_widget_area(), with preg_replace

Similar to how the postinfo items work

mdmower May 11, 2011 03:04 PM

When I wrote the fix for RFE: allow selectable document mode for IE, I used php echo, so I had to escape double quotation marks. Since you prefer to kill php with ?> to pass html commands, shouldn't these escaped quotation marks be removed?

Example: header.php, line 14 (and others)
Code:

?><meta http-equiv=\"X-UA-Compatible\" content=\"IE=EmulateIE7\"/>
should read
Code:

?><meta http-equiv="X-UA-Compatible" content="IE=EmulateIE7"/>

vincent May 11, 2011 04:56 PM

Do any of the changes offer speed improvements?
thanks,

- Vincent

Flynn May 11, 2011 06:36 PM

Quote:

Originally Posted by mdmower (Post 65190)
When I wrote the fix for RFE: allow selectable document mode for IE, I used php echo, so I had to escape double quotation marks. Since you prefer to kill php with ?> to pass html commands, shouldn't these escaped quotation marks be removed?

Example: header.php, line 14 (and others)
Code:

?><meta http-equiv=\"X-UA-Compatible\" content=\"IE=EmulateIE7\"/>
should read
Code:

?><meta http-equiv="X-UA-Compatible" content="IE=EmulateIE7"/>

You're right, thanks

Added to 3.6.7 which I hope to release in an hour or two

mdmower May 12, 2011 01:34 PM

3.6.7 very minor details:
In theme options, start page still says "New in 3.6.6:"
Green update notice still appears "Atahualpa - version 3.6.6 available. Have a look"
Readme.txt file lists "3.6.5"

juggledad May 12, 2011 01:36 PM

BUGFIX - see http://forum.bytesforall.com/showpos...94&postcount=4

juggledad May 12, 2011 07:07 PM

Please open new threads to report problems with 3.6.7

I've move the several issues to separate threads to make it easier to track the issues.

Closing this thread.


All times are GMT -6. The time now is 02:35 AM.

Powered by vBulletin® Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.